Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add resources limits to linked container as required #393

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix: add resources limits to linked container as required #393

merged 1 commit into from
Dec 4, 2024

Conversation

shreddedbacon
Copy link
Member

Fixes the missing limits on linked containers

closes #391

@shreddedbacon shreddedbacon added this to the 2.23.0 milestone Nov 24, 2024
@shreddedbacon shreddedbacon marked this pull request as ready for review November 24, 2024 21:01
@shreddedbacon shreddedbacon mentioned this pull request Dec 4, 2024
Merged
tobybellwood
tobybellwood approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me - test coverage here is enough to assert correct functionality

@shreddedbacon shreddedbacon merged commit 3668bc0 into main Dec 4, 2024
2 checks passed
@shreddedbacon shreddedbacon deleted the linked-resource-limit branch December 4, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.23.0
Development

Successfully merging this pull request may close these issues.

Secondary linked container doesn't respect resource limits
2 participants
@shreddedbacon @tobybellwood