C-based: put markers to signature #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
If a default-string literal or a default-char literal is included in a signature, the marker of the literal should be recorded as part of the signature. The original code didn't record the markers. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3804 +/- ##
==========================================
+ Coverage 83.04% 85.07% +2.03%
==========================================
Files 227 226 -1
Lines 55203 53851 -1352
==========================================
- Hits 45843 45814 -29
+ Misses 9360 8037 -1323
☔ View full report in Codecov by Sentry. |
jafl
approved these changes
Aug 19, 2023
|
I didn't consider vera.c. Maybe we must update it, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C-based: put literal markers (' and ") to signatures
If a default-string literal or a default-char literal is included in a signature, the marker of the literal should be recorded as part of the signature.
The original code didn't record the markers.