Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript: Fix handling of parentheses in class property value #3659

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

b4n
Copy link
Member

@b4n b4n commented Mar 4, 2023

See geany/geany#3416

Disclaimer: I don't know TypeScript so I'm trusting the input file, and it'd be great if anybody having any knowledge here could review :)

@codecov
Copy link

codecov bot commented Mar 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (9e62e16) 82.82% compared to head (f85c988) 82.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3659   +/-   ##
=======================================
  Coverage   82.82%   82.83%           
=======================================
  Files         223      223           
  Lines       54506    54508    +2     
=======================================
+ Hits        45147    45149    +2     
  Misses       9359     9359           
Impacted Files Coverage Δ
parsers/typescript.c 91.89% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@masatake masatake requested a review from ksamborski March 5, 2023 00:49
@ksamborski
Copy link
Member

LGTM

@ksamborski
Copy link
Member

@masatake feel free to merge it

@masatake masatake merged commit bd568be into universal-ctags:master Mar 5, 2023
@masatake
Copy link
Member

masatake commented Mar 5, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants