check the file output error more frequently #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masatake
force-pushed
the
more-ferror
branch
from
afa8783 to
712db72
Compare
| if (fclose (TagFile.fp) != 0) | ||
| { | ||
| error (FATAL | PERROR, "cannot close tag file"); | ||
| exit (1); |
There was a problem hiding this comment.
error(FATAL) will exit itself, so the exit(1) is dead code. And if didn't, abort_if_ferror() should also exit() then.
masatake
force-pushed
the
more-ferror
branch
from
712db72 to
59ee558
Compare
… if found exit(1) is removed as suggested by @b4n. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
fflush can also report a file related error. So abort_if_ferror should be called after fflush. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
exit(1) is removed as suggested by @b4n. Signed-off-by: Masatake YAMATO <yamato@redhat.com>
Signed-off-by: Masatake YAMATO <yamato@redhat.com>
masatake
force-pushed
the
more-ferror
branch
from
59ee558 to
c389dd0
Compare
masatake
added a commit
that referenced
this pull request
Feb 25, 2015
check the file output error more frequently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original code introducing ferror doesn't check errors in endTagsFile, closeTagsFile and writePseudoTag.