CXX: Improve parsing of function-try-blocks and try/catch in general #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masatake
requested changes
May 2, 2018
| @@ -1 +1,4 @@ | |||
| --c++-kinds=+pflz | |||
parsers/cxx/cxx_parser.c
Outdated
|
|
||
| // and extract variable declarations if possible | ||
| cxxParserExtractVariableDeclarations(pChain,0); | ||
| ); |
There was a problem hiding this comment.
Visual Studio makes a warning on this line (https://ci.appveyor.com/project/universalctags/ctags/build/1.0.763/job/wim07v3kr02a88r6). How about using trigraph like:
bOkToExtractVariables = cxxTokenChainNextTokenOfType(
pAndOrStar,
CXXTokenTypeAssignment | CXXTokenTypeSemicolon
)? true: false;
or ...
} else if ( cxxTokenChainNextTokenOfType(
pAndOrStar,
CXXTokenTypeAssignment | CXXTokenTypeSemicolon)) {
bOkToExtractVariables = true;
}
parsers/cxx/cxx_tag.c
Outdated
| @@ -286,6 +286,9 @@ vString * cxxTagSetProperties(unsigned int uProperties) | |||
| vStringCatS(pszProperties,_szProperty); \ | |||
| } while(0) | |||
|
|
|||
| // FIXME: The property names might be too verbose. Maybe it could be a good idea | |||
| // to a switch to shorten them to 1-2 letter codes? | |||
|
|
|||
There was a problem hiding this comment.
I think basically using long names is not bad.
Making shortere can be done in a post processor.
masatake
approved these changes
May 8, 2018
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved solution for #1746.
-- the variables declared inside now have proper scope
-- the function ends after the last catch()