Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clojure: skip metadata in namespace definition #1743

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Clojure: skip metadata in namespace definition #1743

merged 1 commit into from
Apr 23, 2018

Conversation

masatake
Copy link
Member

Close #1657.

Signed-off-by: Masatake YAMATO yamato@redhat.com

@masatake
Clojure: skip metadata in namespace definition
9342384 
Close universal-ctags#1657.

Signed-off-by: Masatake YAMATO <yamato@redhat.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.006%) to 84.829% when pulling 9342384 on masatake:clojure-fix-namespace-handling into 70dd618 on universal-ctags:master.

@masatake masatake mentioned this pull request Apr 20, 2018
Closed
@arichiardi
Copy link

Will try it tomorrow for sure! Thank you 😄

@arichiardi
Copy link

@masatake tried it and it is good for me!

$ cat tags 
!_TAG_FILE_FORMAT	3	/extended format with meta character escaping/
!_TAG_FILE_SORTED	1	/0=unsorted, 1=sorted, 2=foldcase/
!_TAG_PROGRAM_AUTHOR	Universal Ctags Team	//
!_TAG_PROGRAM_NAME	Universal Ctags	/Derived from Exuberant Ctags/
!_TAG_PROGRAM_URL	https://ctags.io/	/official site/
!_TAG_PROGRAM_VERSION	0.0.0	/9342384/
ep-cloud.util	src/ep_cloud/util.cljc	/^(ns ^{:doc "Utility functions."} ep-cloud.util$/;"	n
js->clj*	src/ep_cloud/util.cljc	/^   (defn js->clj*$/;"	f	namespace:ep-cloud.util
js-merge	src/ep_cloud/util.cljc	/^   (defn js-merge$/;"	f	namespace:ep-cloud.util
local-invocation?	src/ep_cloud/util.cljc	/^   (defn local-invocation?$/;"	f	namespace:ep-cloud.util
offline-invocation?	src/ep_cloud/util.cljc	/^   (defn offline-invocation?$/;"	f	namespace:ep-cloud.util
spec-valid-as-promise	src/ep_cloud/util.cljc	/^   (defn spec-valid-as-promise$/;"	f	namespace:ep-cloud.util
through	src/ep_cloud/util.cljc	/^   (defn through$/;"	f	namespace:ep-cloud.util
transform-keys	src/ep_cloud/util.cljc	/^(defn transform-keys$/;"	f	namespace:ep-cloud.util
trim-ex-data	src/ep_cloud/util.cljc	/^   (defn trim-ex-data$/;"	f	namespace:ep-cloud.util

@masatake
Copy link
Member Author

@arichiardi, thank you.

@masatake masatake merged commit 2799cd3 into universal-ctags:master Apr 23, 2018
@masatake
Copy link
Member Author 

$ cat tags 
!_TAG_FILE_FORMAT	3	/extended format with meta character escaping/

I found I mistakenly merged format-3 branch.

@arichiardi
Copy link

Oh, didn't noticed that, the output was good to me 😏

@masatake
Copy link
Member Author

Please, ignore what I wrote in the last comment; it is nothing to do with the clojure parser.
...I wonder what I should do for the mistake....

@arichiardi
Copy link

Can you revert the commit and apply the fix on master the old HEAD?

@masatake
Copy link
Member Author

@arichiardi, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@masatake @coveralls @arichiardi