Fix: estimator getter and lagged_label_name #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2246 +/- ##
==========================================
+ Coverage 93.95% 93.97% +0.01%
==========================================
Files 135 135
Lines 13501 13511 +10
==========================================
+ Hits 12685 12697 +12
+ Misses 816 814 -2 ☔ View full report in Codecov by Sentry. |
dennisbader
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Thanks for this @madtoinou.
Had some minor suggestions about target lags naming, and simplifying the test.
Maybe we can extend the get get_multioutput_estimator to get_estimator that retrieves the correct estimator, regardless whether it's a multi output model or not?
…into fix/regmodel_bugs
dennisbader
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2217.
Summary
get_multioutput_estimator()where the incorrect estimator could be returnedOther Information