Fix/lighter workflows #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes workflows causing tests to run multiple times.
Summary
The previous version of the "darts develop workflow" triggered twice when pushing to a branch on the repo which also had an opened PR, causing a lot of duplicate tests. I propose to remove the trigger on pushes to branches different from {master, develop}. This way, the workflow is only triggered for opened PRs (the idea being that before opening a PR, tests can still easily be run locally, so we don't loose much) and this should remove the duplicate tests situation.
I also made the "darts develop workflow" lighter, only checking for os ubuntu-latest, python-version: [3.6, 3.7, 3.8] and flavour ['core', 'all'], and conversely made the "merge PR workflow" more comprehensive (with os: [macos-latests, ubuntu-latests], python-version [3.6, 3.7, 3.8] and all possible flavors.