Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/beta nll #1162

Merged
merged 8 commits into from
Aug 25, 2022
Merged

Feat/beta nll #1162

merged 8 commits into from
Aug 25, 2022

Conversation

hrzn
Copy link
Contributor

@hrzn hrzn commented Aug 21, 2022 •
edited
Loading

  • Addresses beta-NLL #972
  • Corrects a bug in GaussianLikelihood, where we were using the standard dev instead of the variance 😱

@hrzn hrzn linked an issue Aug 21, 2022 that may be closed by this pull request
beta-NLL #972
Closed
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2022 •
edited
Loading

Codecov Report

Merging #1162 (de4c67d) into master (f953005) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##           master    #1162      +/-   ##
==========================================
- Coverage   93.65%   93.64%   -0.02%     
==========================================
  Files          80       80              
  Lines        8295     8287       -8     
==========================================
- Hits         7769     7760       -9     
- Misses        526      527       +1
Impacted Files Coverage Δ
darts/utils/likelihood_models.py 96.04% <87.50%> (-0.17%) ⬇️
darts/timeseries.py 92.23% <0.00%> (-0.07%) ⬇️
...arts/models/forecasting/torch_forecasting_model.py 87.45% <0.00%> (-0.05%) ⬇️
darts/models/forecasting/block_rnn_model.py 98.24% <0.00%> (-0.04%) ⬇️
darts/models/forecasting/nhits.py 98.55% <0.00%> (-0.02%) ⬇️
darts/datasets/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hrzn hrzn merged commit 46af29e into master Aug 25, 2022
@madtoinou madtoinou deleted the feat/beta-nll branch July 5, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdevos010 gdevos010 gdevos010 approved these changes

@dennisbader dennisbader Awaiting requested review from dennisbader dennisbader is a code owner

@brunnedu brunnedu Awaiting requested review from brunnedu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

beta-NLL
3 participants
@hrzn @codecov-commenter @gdevos010