feat: add edit.dependents
#5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryairani
reviewed
Nov 26, 2024
aryairani
approved these changes
Nov 26, 2024
For this PR, I think you should
Alternatively, you could
The result should be the same either way. the latter maybe gives a bit more confidence that the new transcript results match the ones you got before merging in trunk. |
|
bump @mitchellwrosen re merge conflicts |
|
@aryairani Oops, done now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds a small variant of
editthat also grabs all of the thing's transitive dependents. This is intended as sort of a temporary solution to the known issue of ending up in the following situation:foodepends onbardepends onBazfooandBazare in the scratch fileBazis changed in the file but not saved to the codebase yetfooare missing names, because it's callingbarwhich is still calling old-now-namelessBazThe fix in this small example is to
edit bar, but more generally anedit.dependents Bazhere will do what you want – get the full transitive closure of dependents in the file (so that any changes toBazare fully propagated within the file).Interesting/controversial decisions
Not very controversial, but I also made it so temporary output messages that are displayed only within a console region are now also visible in transcripts. Ever
mergein a transcript is now a lot more verbose but I think that's totally fine because transcripts are meant to capture ucm output.Test coverage
I've added a new transcript. I tried just adding onto the end of
edit-command.md, but was getting really strange results. You can already see in that transcript one instance of spookiness that was worked around just by repeating a stanza. Our transcript runner has some terrible bug.