CI-improvements #962
Merged
CI-improvements #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that you can actually see what you need to change, not just the fact that there's a problem
Before, if one failed, then it stopped early. It's nice to see all problems early though so you can fix everything at the same time.
Codecov ReportBase: 96.68% // Head: 96.68% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #962 +/- ##
=======================================
Coverage 96.68% 96.68%
=======================================
Files 42 42
Lines 4197 4197
=======================================
Hits 4058 4058
Misses 139 139 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
cosmicBboy
reviewed
Oct 18, 2022
| @@ -62,12 +62,15 @@ jobs: | |||
| run: pre-commit run isort --all-files | |||
|
|
|||
| - name: Black | |||
| if: always() | |||
There was a problem hiding this comment.
this command is new to me, looks helpful!
wondering tho, shouldn't this be ${{ always() }} ?
There was a problem hiding this comment.
It magically works without the brackets :)
There was a problem hiding this comment.
See https://github.com/dedupeio/dedupe/actions/runs/3261890751/workflow for an example :)
cosmicBboy
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes things a little easier for me, who was drive by editing on github.dev, therefore I didn;t have the local linting tools so I was relying on the CI linters more.