Font subsetting and font optimization improvements #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will support both font file reduction and subsetting. (WIP)
Covers XObject Forms, annotaitons etc. Uses extractor package to extract text marks covering what fonts and glyphs are used. Package truetype used for subsetting.
Codecov Report
@@ Coverage Diff @@
## development #362 +/- ##
===============================================
- Coverage 62.39% 56.16% -6.24%
===============================================
Files 236 239 +3
Lines 45802 46206 +404
===============================================
- Hits 28580 25951 -2629
- Misses 16549 16905 +356
- Partials 673 3350 +2677
Continue to review full report at Codecov.
|
…tion-improvements
gunnsth
changed the title
adrg
reviewed
Jun 13, 2020
| for _, obj := range kids.Elements() { | ||
| pobj, ok := core.GetIndirect(obj) | ||
| if !ok { | ||
| break |
There was a problem hiding this comment.
Should this be continue here instead of break?
There was a problem hiding this comment.
This is something that should not happen, I think. Might make sense to log a debug message. It's part of the optimization so it's not very mission critical.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is focused on improving some optimization methods, mostly for font optimization, but also some other approaches.
NewFromContentsto extractor to enable extracting from generic pdf contents / resources.Note that some golint fixes mixed in also.
This change is