Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subsetting fixes #346

Merged
merged 4 commits into from
May 12, 2020
Merged

Subsetting fixes #346

merged 4 commits into from
May 12, 2020

Conversation

gunnsth
Copy link
Contributor

@gunnsth gunnsth commented May 11, 2020 •
edited
Loading

  • Updates unitype to newest version, where subsetting has been improved
  • Better handling of composite glyphs etc, where previously glyphs were sometimes missing after subsetting.
  • Fixes some files provided by customers that were missing glyphs.

This change is Reviewable

@codecov
Copy link

codecov bot commented May 11, 2020 •
edited
Loading

Codecov Report

Merging #346 into development will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #346      +/-   ##
===============================================
+ Coverage        52.43%   52.64%   +0.21%     
===============================================
  Files              236      236              
  Lines            45715    45715              
===============================================
+ Hits             23969    24067      +98     
+ Misses           18655    18545     -110     
- Partials          3091     3103      +12
Impacted Files Coverage Δ
internal/textencoding/truetype.go 40.00% <ø> (ø)
model/font.go 51.73% <ø> (+2.76%) ⬆️
contentstream/parser.go 61.93% <0.00%> (+0.64%) ⬆️
internal/textencoding/simple.go 78.15% <0.00%> (+1.68%) ⬆️
model/font_composite.go 57.77% <0.00%> (+1.97%) ⬆️
internal/textencoding/identity.go 43.33% <0.00%> (+6.66%) ⬆️
extractor/text.go 47.42% <0.00%> (+6.72%) ⬆️
extractor/utils.go 46.15% <0.00%> (+20.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aef6e5e...184fd1a. Read the comment docs.

@gunnsth gunnsth requested a review from adrg May 11, 2020 08:51
adrg
adrg approved these changes May 11, 2020
View reviewed changes
Copy link
Collaborator

@adrg adrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left one comment regarding a minor typo in notes of the SubsetRegistered methods.

internal/textencoding/truetype.go Outdated
@@ -31,6 +31,7 @@ type TrueTypeFontEncoder struct {
}

// SubsetRegistered subsets `enc` to only registered runes (that have been registered via encoding).
// NOTE: Make sure to call this soon before writing (once all needed runes has been registered).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo in the note: has been registered instead of have been registered.
Same in the note from model/font.go.

@gunnsth gunnsth merged commit ad2a1e9 into unidoc:development May 12, 2020
@gunnsth gunnsth deleted the dev-subsetting-fixes branch May 12, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrg adrg adrg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gunnsth @adrg