Add timestamp signature handler #301

a5i · 2020-04-09T22:04:27Z

This change is

codecov · 2020-04-09T22:26:13Z

Codecov Report

Merging #301 into development will decrease coverage by 9.93%.
The diff coverage is 54.12%.

@@               Coverage Diff               @@
##           development     #301      +/-   ##
===============================================
- Coverage        62.24%   52.30%   -9.94%     
===============================================
  Files              235      236       +1     
  Lines            45395    45556     +161     
===============================================
- Hits             28256    23828    -4428     
- Misses           16498    18650    +2152     
- Partials           641     3078    +2437

Impacted Files	Coverage Δ
model/sighandler/sighandler_pkcs7.go	`52.87% <ø> (-9.20%)`	⬇️
model/sighandler/sighandler_timestamp.go	`53.27% <53.27%> (ø)`
model/signature_handler.go	`55.85% <100.00%> (-14.79%)`	⬇️
internal/jbig2/globals.go	`0.00% <0.00%> (-100.00%)`	⬇️
internal/e2etest/memory_measure.go	`0.00% <0.00%> (-100.00%)`	⬇️
internal/jbig2/decode.go	`0.00% <0.00%> (-80.00%)`	⬇️
internal/e2etest/utils.go	`0.00% <0.00%> (-80.00%)`	⬇️
internal/e2etest/validate.go	`0.00% <0.00%> (-80.00%)`	⬇️
model/flatten.go	`0.00% <0.00%> (-76.15%)`	⬇️
annotator/field_appearance.go	`10.83% <0.00%> (-44.96%)`	⬇️
... and 157 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 971a00f...cf88c9b. Read the comment docs.

gunnsth · 2020-04-10T23:49:53Z

@a5i Can you add documentation and example/testcase how to combine signing and timestamping also.

If we follow PAdES signature flow we need to append digital signature to PDF and after it add timestamp signature. We should use the next algorithm

save/generate a document with digital sign with Appender

open the document and save/generate the document with timestamp sign with Appender

Would be good to have a testcase that does this.

adrg

Looks good overall. I added a couple of observations.

model/sighandler/sighandler_timestamp.go

model/appender_test.go

model/sighandler/sighandler_timestamp.go

model/appender_test.go

model/signature_handler.go

adrg

I left two minor observations. Other than that, everything looks good to me.

adrg · 2020-04-21T14:31:30Z

model/sighandler/sighandler_timestamp.go

+	}
+
+	if resp.StatusCode != http.StatusOK {
+		return fmt.Errorf("http status code wiats 200 got %d", resp.StatusCode)


Please correct the error message. Also, might be more efficient to do the status code check before ioutil.ReadAll(resp.Body) as the body is not relevant if the request was not successful. Another option would be to leave the status code check where it is now and also print the response body in order to identify the issue easily (maybe print the response body in a common.Log.Debug call for status != 200).

model/sighandler/sighandler_timestamp.go

gunnsth

LGTM

Add timestamp signature handler

f927ba8

gunnsth changed the base branch from master to development April 9, 2020 23:06

gunnsth requested a review from adrg April 9, 2020 23:07

Add timestamp signature handler test

eb21508

adrg reviewed Apr 13, 2020

View reviewed changes

gunnsth reviewed Apr 16, 2020

View reviewed changes

model/appender_test.go Show resolved Hide resolved

gunnsth requested a review from adrg April 17, 2020 14:44

fix PR issues

212d8f1

gunnsth reviewed Apr 18, 2020

View reviewed changes

model/signature_handler.go Show resolved Hide resolved

fix PR issues

ce3d393

adrg reviewed Apr 21, 2020

View reviewed changes

fix PR issues

3c75f9a

gunnsth approved these changes Apr 22, 2020

View reviewed changes

Fix

cf88c9b

gunnsth merged commit a69d788 into unidoc:development Apr 22, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add timestamp signature handler #301

Add timestamp signature handler #301

a5i commented Apr 9, 2020 •

edited by gunnsth

Loading

codecov bot commented Apr 9, 2020 •

edited

Loading

gunnsth commented Apr 10, 2020

adrg left a comment

adrg left a comment

adrg Apr 21, 2020

gunnsth left a comment

Add timestamp signature handler #301

Add timestamp signature handler #301

Conversation

a5i commented Apr 9, 2020 • edited by gunnsth Loading

codecov bot commented Apr 9, 2020 • edited Loading

Codecov Report

gunnsth commented Apr 10, 2020

adrg left a comment

Choose a reason for hiding this comment

adrg left a comment

Choose a reason for hiding this comment

adrg Apr 21, 2020

Choose a reason for hiding this comment

gunnsth left a comment

Choose a reason for hiding this comment

a5i commented Apr 9, 2020 •

edited by gunnsth

Loading

codecov bot commented Apr 9, 2020 •

edited

Loading