Skip to content

v0.1.13 breaks semver #55

Closed as not planned
Closed as not planned
@joshka

Description

In ratatui, running cargo update from v0.1.12 to v0.1.13 results in the latter failing (something has changed in the way that unicode-width handles zero width strings

Error from our tests

--- STDOUT: ratatui buffer::buffer::tests::set_string_zero_width ---

running 1 test
test buffer::buffer::tests::set_string_zero_width ... FAILED

failures:

failures:
buffer::buffer::tests::set_string_zero_width

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 1557 filtered out; finished in 0.00s

--- STDERR: ratatui buffer::buffer::tests::set_string_zero_width ---
thread 'buffer::buffer::tests::set_string_zero_width' panicked at src/buffer/buffer.rs:618:9:
assertion left == right failed
left: Buffer {
area: Rect { x: 0, y: 0, width: 1, height: 1 },
content: [
"",
],
styles: [
x: 0, y: 0, fg: Reset, bg: Reset, modifier: NONE,
]
}
right: Buffer {
area: Rect { x: 0, y: 0, width: 1, height: 1 },
content: [
"a",
],
styles: [
x: 0, y: 0, fg: Reset, bg: Reset, modifier: NONE,
]
}

I'd suggest yanking 0.1.13 and publishing the latest release as 0.2.0 instead.

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions