Serde impls for VarULE types (Var tuple types, and make_var) #5802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
var-serde
branch
from
6bffc5d to
fb908a2
Compare
sffc
previously approved these changes
Nov 9, 2024
There was a problem hiding this comment.
The impls look about right; can you add more tests? Most serde impls I write have a test that puts them inside of a Cow in a struct with #[derive(Serialize, Deserialize)] and then runs them with both JSON and bincode/postcard and tests that they round-trip and borrow/own correctly.
|
Oh yeah I was planning to test more but it was becoming the weekend so i wrapped up. I'll add tests and fix things when I get a chance. |
|
Added some tests. We do keep hitting rust-lang/rust#130180 :/ |
sffc
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing these.
This also gives me a much clearer idea of what's needed in #5561. I might go and implement that, but I may also just use what we have for now for DecimalSymbolsV1.