Add TupleNVarULE #5777
Merged
Add TupleNVarULE #5777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
tuplevar
branch
3 times, most recently
from
654bc46 to
909f006
Compare
|
Hm, my serde impls here aren't optimal for postcard, I think |
sffc
reviewed
Nov 6, 2024
Manishearth
force-pushed
the
tuplevar
branch
2 times, most recently
from
1847375 to
b59b2ab
Compare
sffc
approved these changes
Nov 7, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VarULE counterpart of TupleNULE
Part of #5523. Planned to be used in #4437
I'm not super happy with the naming with this vs VarTupleULE, but I've tried to make it clearer with the module names and it's fine for now. We can rename as desired since zerovec isn't on the ICU4X stability track.
I do plan to add serde/etc impls but that's going to be a separate PR.