Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support localized offsets with seconds #5674

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Support localized offsets with seconds #5674

merged 2 commits into from
Oct 14, 2024

Conversation

robertbastian
Copy link
Member

Fixes #5638

Manishearth
Manishearth previously approved these changes Oct 13, 2024
View reviewed changes
sffc
sffc requested changes Oct 14, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually wait, I think it is supposed to be % 60, right?

components/datetime/src/time_zone.rs Outdated Show resolved Hide resolved
@robertbastian @sffc
Update components/datetime/src/time_zone.rs
2bab5b9 
Co-authored-by: Shane F. Carr <shane@unicode.org>
@robertbastian robertbastian requested a review from sffc October 14, 2024 16:02
@sffc sffc merged commit 4863bfc into unicode-org:main Oct 14, 2024
27 checks passed
@robertbastian robertbastian deleted the seconds branch October 14, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc approved these changes

@Manishearth Manishearth Manishearth left review comments

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support short localized GMT format and GMT format with seconds
3 participants
@robertbastian @sffc @Manishearth