Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormattableMonth -> MonthInfo, and split standard from formatting month codes #5536

Merged
merged 9 commits into from
Sep 13, 2024

Conversation

Manishearth
Copy link
Member

Also some leftover cleanups in the FFI allowlist from #5509

Fixes #3821

sffc
sffc previously approved these changes Sep 12, 2024
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe reconsider the name of ordinal

@Manishearth
Copy link
Member Author

Yeah, I think I prefer ordinal over extended_month. ordinal is clear about what it actually does, extended has always been confusing for me and it makes some sense in the context of years (where it's also a term of art) but it's different here.

@sffc
Copy link
Member

sffc commented Sep 12, 2024

In the issue I said:

The one people should generally be using though is standard_code, but it is really tempting to reach for ordinal. So I feel like we should prefix all three.

@Manishearth
Copy link
Member Author

That doesn't quite make sense to me: ordinal is already the disambiguator, it doesn't say code because it's not a code. All three of them have weird names, just that two of them have two-part names because they're also codes. I could call it ordinal_number instead if that brings them more in line, though personally I'm not sold on the value of doing that (but happy to do it if you find it valuable).

@sffc
Copy link
Member

sffc commented Sep 13, 2024

(clippy is still failing)

@Manishearth Manishearth merged commit 40a68b4 into unicode-org:main Sep 13, 2024
28 checks passed
@Manishearth Manishearth deleted the month-refactor branch September 13, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix FormattableMonth for leap months and FormattableYear for shared eras
2 participants