Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a borrowed version of the collator #5513

Merged
merged 22 commits into from
Sep 11, 2024

Conversation

hsivonen
Copy link
Member

@hsivonen hsivonen commented Sep 6, 2024

Addresses #5187 for the collator.

@hsivonen hsivonen added C-collator Component: Collation, normalization 2.0-breaking Changes that are breaking API changes labels Sep 6, 2024
components/collator/src/comparison.rs Outdated Show resolved Hide resolved
ffi/capi/tests/missing_apis.txt Outdated Show resolved Hide resolved
components/collator/src/comparison.rs Outdated Show resolved Hide resolved
@sffc
Copy link
Member

sffc commented Sep 10, 2024

I trust @robertbastian to review this but I can take a look if you need to. The Normalizer PR was good so I don't anticipate any major issues.

@Manishearth Manishearth removed their request for review September 10, 2024 14:57
components/collator/benches/bench.rs Outdated Show resolved Hide resolved
components/collator/src/lib.rs Outdated Show resolved Hide resolved
components/collator/src/options.rs Outdated Show resolved Hide resolved
components/collator/tests/tests.rs Outdated Show resolved Hide resolved
tools/make/diplomat-coverage/src/allowlist.rs Outdated Show resolved Hide resolved
@hsivonen hsivonen merged commit 0211e47 into unicode-org:main Sep 11, 2024
28 checks passed
@hsivonen hsivonen deleted the collatorborrowedbis branch September 12, 2024 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.0-breaking Changes that are breaking API changes C-collator Component: Collation, normalization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants