Move DatagenProvider into its own crate
#5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
dgp
branch
6 times, most recently
from
e45c746 to
a8686e5
Compare
robertbastian
force-pushed
the
dgp
branch
4 times, most recently
from
29ee634 to
c5d470b
Compare
Manishearth
reviewed
Jun 18, 2024
robertbastian
force-pushed
the
dgp
branch
3 times, most recently
from
f83ba23 to
ba551b6
Compare
|
this is split now |
sffc
approved these changes
Jun 20, 2024
| # (online at: https://github.com/unicode-org/icu4x/blob/main/LICENSE ). | ||
|
|
||
| [package] | ||
| name = "icu_datagen_bikeshed" |
There was a problem hiding this comment.
We were trying to decide between icu_provider_source and icu_provider_transform?
There was a problem hiding this comment.
icu_provider_datagen was also in the mix I think
robertbastian
added a commit
that referenced
this pull request
Jun 20, 2024
Reduces the number of files lying around, and in #5016 it'll be more difficult to generate hello world blobs with fallback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4721
provider/datagen/src/{provider.rs, provider/, transform/}move toprovider/bikeshed/src.Stubdata moves to
provider/data/{component}/stubdata, as it's a quality-of-life thing and not required for testing or reviewing theDatagenProvider(also,../stubdatais a much nicer value forICU4X_DATA_DIRthan../../../bikeshed/tests/data/baked). JSON testdata moves toprovider/bikeshed/data/debug, as it's used only for debugging/reviewing, and shouldn't be intests/data, which is data that actually affects tests.