-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the registry into its own crate #5010
Conversation
I thought the registry was going to the |
It leads to a circular dependency for the broken-out datagen provider, and it's also pretty inefficient to pull in all of ICU4X just for some tokens. |
How?
The tokens are symbols of the |
It's entirely feasible to write a datagen script that uses only one subcomponent. It shouldn't pull in all of ICU4X. Please let me do the refactorings, if we can identify a crate to fold it into after everything is done, Im happy to do that. It might be icu_provider. |
icu > icu_list > icu_provider_baked > icu. The last link is with the export feature only, but that doesn't matter for circularity. |
What is |
You don't need the registry; it's mainly useful when you need to branch over all
ok |
baked_exporter needs the registry |
3346421
to
18714a6
Compare
#4721