Remove icu_datagen legacy API
#4962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sffc
reviewed
May 29, 2024
Comment on lines
-159
to
-162
| #[arg(long, hide = true)] | ||
| #[arg(help = "Deprecated: alias for --keys all")] | ||
| all_keys: bool, | ||
|
|
There was a problem hiding this comment.
Nit: We've been piloting the new names for a while, but I still use --all-keys --all-locales because I find them easier to remember than --keys all --locales full. Please pull these two specific removals to their own PR
sffc
previously approved these changes
May 29, 2024
Manishearth
previously approved these changes
May 29, 2024
|
@sffc remind me what the replacement for --fallback preresolved is again? Need to update these: https://github.com/search?q=repo%3Aunicode-org%2Ficu4x%20%22--fallback%22&type=code |
|
I guess it's just |
sffc
previously approved these changes
May 29, 2024
sffc
previously approved these changes
May 29, 2024
sffc
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4960