Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dart diplomat update #4333

Merged
merged 10 commits into from
Nov 21, 2023
Merged

Dart diplomat update #4333

merged 10 commits into from
Nov 21, 2023

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Nov 20, 2023

Removes formatting, fixes #4291

@robertbastian robertbastian requested a review from mosuem November 20, 2023 09:38
@robertbastian robertbastian requested review from Manishearth and a team as code owners November 20, 2023 09:38
@robertbastian robertbastian requested a review from sffc as a code owner November 20, 2023 09:41
@robertbastian
Copy link
Member Author

#3006

@robertbastian
Copy link
Member Author

Actually not sure if we want this, it will break 2.x compat

@mosuem
Copy link

mosuem commented Nov 20, 2023

It's completely fine to go to min SDK version 3.0.0

@robertbastian robertbastian changed the title Marking Dart classes final Dart diplomat update Nov 20, 2023
@robertbastian robertbastian merged commit c5a67b8 into unicode-org:main Nov 21, 2023
29 checks passed
@robertbastian robertbastian deleted the dart branch November 28, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix up workflow of dart formatting in diplomat-gen
3 participants