Fix Unicode 15.0 sentence segmentation #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggrobin
force-pushed
the
import-monkeys
branch
from
ddc4c8a to
9403d59
Compare
eggrobin
force-pushed
the
import-monkeys
branch
2 times, most recently
from
717632c to
ae91e72
Compare
eggrobin
force-pushed
the
import-monkeys
branch
from
ae91e72 to
c97b87f
Compare
eggrobin
changed the title
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com>
eggrobin
requested review from
a team,
sffc,
Manishearth,
aethanyc and
makotokato
as code owners
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com>
Co-authored-by: Robert Bastian <4706271+robertbastian@users.noreply.github.com>
…to import-monkeys
This reverts commit 21aca87.
robertbastian
previously approved these changes
Oct 25, 2023
robertbastian
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4038.
Seems to work now; tested with 1 000 000 test cases (I’m not going to check that in) and the last failure I encountered so far was #79. I should try an overnight test though.
Outline of the monkey testing process:
In ICU, at https://github.com/eggrobin/icu/tree/export-monkeys-15.0:
In ICU4X:
Stare at the weeping tests (you will want to cherry-pick the traces from 21aca87), fix something in the state-transition table,
cd ..\..; cargo make bakeddata components/segmenter; cd components\segmenterAnd back to
Repeat until the heat death of the universe.