Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-21733 Fix build of ICU C++ Locale Explorer demo #28

Merged
merged 1 commit into from
Oct 8, 2021
Merged

ICU-21733 Fix build of ICU C++ Locale Explorer demo #28

merged 1 commit into from
Oct 8, 2021

Conversation

sven-oly
Copy link
Contributor

@sven-oly sven-oly commented Oct 7, 2021 •
edited by srl295
Loading

@sven-oly sven-oly requested review from srl295 and erik0686 October 7, 2021 22:30
srl295
srl295 approved these changes Oct 8, 2021
View reviewed changes
Copy link
Member

@srl295 srl295 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't check images but lgtm

@srl295
Copy link
Member

srl295 commented Oct 8, 2021 •
edited
Loading

They are in French with the IBM logo…  it's better than broken…

@sven-oly sven-oly merged commit c826a56 into unicode-org:main Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srl295 srl295 srl295 approved these changes

@erik0686 erik0686 Awaiting requested review from erik0686

Assignees

@sven-oly sven-oly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven-oly @srl295