Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add an option to disable Windows Copilot: closes #263 #266

Closed
wants to merge 4 commits into from

Conversation

selivan
Copy link

@selivan selivan commented Oct 3, 2023

No description provided.

@selivan selivan changed the title feat: add optioon to disable Windows Copilot: closes #263 feat: add an option to disable Windows Copilot: closes #263 Oct 3, 2023
@undergroundwires
Copy link
Owner

Hi, thanks for the PR. It looks good. Here is my feedback:

  1. privacy.sexy does not touch HKCU keys. If we do that, we should do that for all policies that's out of the scope of this PR. So to keep it consistent, let's remove HKCU modification.
  2. In docs: property, we could change the source to official Microsoft docs. This is snapshotted official docs that we can use: https://web.archive.org/web/20231004134328/https://learn.microsoft.com/en-us/windows/client-management/mdm/policy-csp-windowsai#turnoffwindowscopilot. This is more reputable source.
  3. I was thinking about the category. Preinstalled is not really good category for this. I know these categories are confusing, I'm working on to document those/flatten and do a better job. Can we move this script to directly under Remove bloatware main category?
  4. Can we just rename this to Disable Windows Copilot for simplicity?

It should be ready to merge then. Let me know if you don't agree/have another opinion or anything needs clarification.

@selivan
Copy link
Author

selivan commented Oct 4, 2023

  • removed lines for HKCU
  • changed name
  • changed docs link
  • moved "Disable Windows Copilot" directly to "Remove Bloatware"

@undergroundwires undergroundwires force-pushed the master branch 6 times, most recently from 093de90 to 67c3677 Compare October 13, 2023 18:14
@undergroundwires undergroundwires force-pushed the master branch 8 times, most recently from 48076fd to d6da406 Compare October 22, 2023 13:04
@undergroundwires undergroundwires force-pushed the master branch 3 times, most recently from af86018 to ca81f68 Compare November 1, 2023 12:39
@undergroundwires undergroundwires force-pushed the master branch 4 times, most recently from ef5b10e to 8ccaec7 Compare November 6, 2023 20:55
@undergroundwires
Copy link
Owner

I was waiting for adding new scripts before feature release. But feature releases come rarely so I will add them as part of patches. So ffrom now on PRs will be merged quicker, this also helps as I'm having such a bad experience for conflict resolving in GitHub.. I'll merge this manually.

undergroundwires added a commit that referenced this pull request Jan 22, 2024
This commit implements scripts to disable Windows Copilot (Copilot in
Windows), addressing issues #263 and #266.

Changes include:

- Add category and scripts to disable Windows copilot.
- Incorporate a restart explorer suggestion across all taskbar
  modification scripts to ensure consistency in user experience.
undergroundwires added a commit that referenced this pull request Jan 22, 2024
This commit implements scripts to disable Windows Copilot (Copilot in
Windows), addressing issues #263 and #266.

Changes include:

- Add category and scripts to disable Windows copilot.
- Incorporate a restart explorer suggestion across all taskbar
  modification scripts to ensure consistency in user experience.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants