Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable clipboard history #251

Closed
wants to merge 3 commits into from
Closed

disable clipboard history #251

wants to merge 3 commits into from

Conversation

SnowzNZ
Copy link
Contributor

@SnowzNZ SnowzNZ commented Sep 3, 2023

adds #247

@undergroundwires
Copy link
Owner

undergroundwires commented Sep 4, 2023

Awesome, thank you @SnowzNZ . I'm happy to receive first PR utilizing more complex logic with functions, these kind of PRs make my job much easier so I can delegate these stuff and focus on some nice features like import/export etc 🥹❤️

  1. Thank you for pointing out double-checking default state, I had W11 21H2 VM with fresh installation when I saw the PR and see that:
  • Default startup mode for services are Automatic not Manual.
  • I see that HKLM\SOFTWARE\Policies\Microsoft\Windows\System\AllowClipboardHistory key does not exist on clean installation. So on revert we should delete the key with reg delete instead of adding 1.
  1. Syntax, after call:, create an array and combine like this:
call:
  - 
     function: DisablePerUserService
     // ..
  - 
     function: RunInlineCode
     parameters:
          code: reg add ...
          revertCode: reg delete..

This way it will be sequence of calls and compiler will handle both. After this syntax change integration and unit tests will be green so it will not break.

@SnowzNZ
Copy link
Contributor Author

SnowzNZ commented Sep 4, 2023

Default startup mode for services are Automatic not Manual.

Changed. I just took the value that the user in the issue used.

I see that HKLM\SOFTWARE\Policies\Microsoft\Windows\System\AllowClipboardHistory key does not exist on clean installation. So on revert we should delete the key with reg delete instead of adding 1.

Changed.

Syntax, after call:, create an array and combine like this: ...

Fixed.

@undergroundwires
Copy link
Owner

Yea, we did not conduct a review of revert logic there. All looks good @SnowzNZ, I will merge this in next minor release.

@undergroundwires undergroundwires added the enhancement New feature or request label Sep 5, 2023
@undergroundwires undergroundwires added this to the 0.13.0 milestone Sep 5, 2023
@undergroundwires undergroundwires force-pushed the master branch 2 times, most recently from 67fbe52 to 65f121c Compare September 9, 2023 20:26
@SnowzNZ SnowzNZ marked this pull request as draft September 14, 2023 21:41
@undergroundwires undergroundwires force-pushed the master branch 13 times, most recently from 3f2a8d7 to cf55ca9 Compare September 29, 2023 12:03
@undergroundwires undergroundwires force-pushed the master branch 3 times, most recently from 35b9dde to 5e359c2 Compare October 8, 2023 13:55
@undergroundwires undergroundwires force-pushed the master branch 8 times, most recently from 8930593 to 3b1a89c Compare January 7, 2024 13:02
@undergroundwires undergroundwires force-pushed the master branch 9 times, most recently from f4efa87 to 756c736 Compare January 15, 2024 21:38
@undergroundwires undergroundwires force-pushed the master branch 9 times, most recently from 1c51622 to 6ada8d4 Compare January 17, 2024 22:59
@undergroundwires undergroundwires marked this pull request as ready for review January 19, 2024 12:51
@undergroundwires
Copy link
Owner

Very simple conflict. I cannot solve this, I will add this manually today.

undergroundwires added a commit that referenced this pull request Jan 19, 2024
This commit adds scripts to secure clipboard by disabling clipboard
synchronization and history. These changes aim to prevent sensitive data
like passwords and credit card details from being inadvertently stored
or shared via the cloud.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants