Bump Electron to latest

- Bump Electron to latest. - Adjust types to new Electron types.
undergroundwires · Jun 20, 2024 · ed93614 · ed93614
1 parent fac26a6
commit ed93614
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 16 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -59,7 +59,7 @@
     "@vue/test-utils": "^2.4.5",
     "autoprefixer": "^10.4.19",
     "cypress": "^13.7.3",
-    "electron": "^29.3.0",
+    "electron": "^31.0.2",
     "electron-builder": "^24.13.3",
     "electron-devtools-installer": "^3.2.0",
     "electron-vite": "^2.1.0",

diff --git a/src/infrastructure/Dialog/Electron/NodeElectronSaveFileDialog.ts b/src/infrastructure/Dialog/Electron/NodeElectronSaveFileDialog.ts
@@ -90,7 +90,7 @@ export class NodeElectronSaveFileDialog implements ElectronSaveFileDialog {
       if (!dialogResult.filePath) {
         return {
           success: false,
-          error: { type: 'DialogDisplayError', message: 'Unexpected Error: File path is undefined after save dialog completion.' },
+          error: { type: 'DialogDisplayError', message: 'Unexpected Error: File path is empty after save dialog completion.' },
         };
       }
       return { success: true, filePath: dialogResult.filePath };

diff --git a/tests/unit/infrastructure/Dialog/Electron/NodeElectronSaveFileDialog.spec.ts b/tests/unit/infrastructure/Dialog/Electron/NodeElectronSaveFileDialog.spec.ts
@@ -305,14 +305,12 @@ describe('NodeElectronSaveFileDialog', () => {
       {
         description: 'unexpected dialog return value failure',
         expectedErrorType: 'DialogDisplayError',
-        expectedErrorMessage: 'Unexpected Error: File path is undefined after save dialog completion.',
+        expectedErrorMessage: 'Unexpected Error: File path is empty after save dialog completion.',
         expectLogs: true,
         buildFaultyContext: (setup) => {
-          const electronMock = new ElectronFileDialogOperationsStub().withMimicUserCancel(false);
-          electronMock.showSaveDialog = () => Promise.resolve({
-            canceled: false,
-            filePath: undefined,
-          });
+          const electronMock = new ElectronFileDialogOperationsStub()
+            .withUserSelectedFilePath('')
+            .withMimicUserCancel(false);
           return setup
             .withElectron(electronMock);
         },