Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make popover work nicely in the button group #296

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Make popover work nicely in the button group #296

merged 2 commits into from
Aug 10, 2022

Conversation

julczka
Copy link
Contributor

@julczka julczka commented Aug 10, 2022

Description

This PR makes the popover component display properly when used inside the button group.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

The reason behind is is to be able to have a dropdown menu in the button group.

Screenshots (if appropriate)

image

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-296.westeurope.azurestaticapps.net

@iOvergaard iOvergaard merged commit a5b3635 into v1/dev Aug 10, 2022
@iOvergaard iOvergaard deleted the bugfix/make-popover-work-with-button-group branch August 10, 2022 13:53
@iOvergaard iOvergaard added bug Something isn't working documentation Improvements or additions to documentation labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iOvergaard iOvergaard iOvergaard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julczka @iOvergaard