Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant downloads mirror #1461

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Remove redundant downloads mirror #1461

merged 1 commit into from
Nov 20, 2020

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Nov 20, 2020

This PR removes the redundant GCP download bucket for weights files. This leaves the GitHub release assets as the sole source of weights, which while less robust is also easier to maintain, as I do not need to update two sets of weights on each release.

I believe the geographic issues we encountered before (i.e. downloading weights in China from Google Drive) should be a non-issue now with the GitHub-hosted weights.

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Minor code refactor and error handling improvements in the YOLOv5 codebase.

📊 Key Changes

  • Commented-out plotting call in test.py now refers to the updated module location utils.plots rather than utils.general.
  • Import statement in autoanchor.py is adjusted to import directly from its own module.
  • A new flag redundant is introduced in google_utils.py to handle a secondary download location in case the primary fails.

🎯 Purpose & Impact

  • Ensures that when plotting is re-enabled in the future, it calls the correct function location, which helps in maintainability. 🛠️
  • Improves code clarity in autoanchor.py by using a direct module reference, making it clearer where functions are coming from. 🧭
  • The change in google_utils.py helps users by providing a fallback download option, ensuring that model weights can still be acquired even if the primary source fails. This enhances the reliability of the download process. 🔄🔗

Potential impact includes:

  • Developers will have less confusion when maintaining or enabling plotting functionalities. 🖊️
  • Users may notice improved error messages and fallback options in case of download issues, easing the setup process. 📥

@glenn-jocher glenn-jocher merged commit a70e554 into master Nov 20, 2020
@glenn-jocher glenn-jocher deleted the comments branch November 20, 2020 12:10
burglarhobbit pushed a commit to burglarhobbit/yolov5 that referenced this pull request Jan 1, 2021
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant