Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Yosys DFF mapping #875

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Fix Yosys DFF mapping #875

merged 1 commit into from
Sep 10, 2024

Conversation

ethanwu10
Copy link
Contributor

Remove -map-only flag that was breaking synthesis, causing many DFFs to be emitted as Yosys internal abstract cells instead of being mapped to the available DFF cells.

Related PRs / Issues

Type of change:

  • Bug fix
  • New feature
  • Other enhancement

Impact:

  • Change to core Hammer
  • Change to a Hammer plugin
  • Other

Contributor Checklist:

  • Did you set master as the base branch?
  • Did you state the type-of-change/impact?
  • Did you delete any extraneous prints/debugging code?
  • (If applicable) Did you add documentation for the feature?
  • (If applicable) Did you update the poetry.lock file if you updated the requirements in pyproject.toml?
  • (If applicable) Did you add a unit test demonstrating the PR?
  • (If applicable) Did you run this through the e2e integration tests?
  • (If applicable) Did you update the submodules in e2e/ if this feature depends on updated plugins?

@ethanwu10
Fix Yosys DFF mapping
bbb1995 
Remove `-map-only` flag that was breaking synthesis, causing many DFFs
to be emitted as Yosys internal abstract cells instead of being mapped
to the available DFF cells.
@ethanwu10 ethanwu10 added this pull request to the merge queue Sep 10, 2024
Merged via the queue into master with commit c501945 Sep 10, 2024
4 checks passed
@ethanwu10 ethanwu10 deleted the sky130-openroad-fixes branch September 10, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nayiri-k nayiri-k nayiri-k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ethanwu10 @nayiri-k