Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import ABC from collections.abc for Python 3.10 compatibility #746

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Import ABC from collections.abc for Python 3.10 compatibility #746

merged 2 commits into from
Apr 14, 2022

Conversation

tirkarthi
Copy link
Contributor

Import ABC from collections was deprecated and removed in Python 3.10. Use collections.abc .

@codecov
Copy link

codecov bot commented Mar 22, 2022 •
edited
Loading

Codecov Report

Merging #746 (92fa19f) into master (26e03c7) will not change coverage.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##           master     #746   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          85       85           
  Lines        5084     5084           
  Branches      787      787           
=======================================
  Hits         4386     4386           
  Misses        559      559           
  Partials      139      139
Impacted Files Coverage Δ
petastorm/predicates.py 76.34% <50.00%> (ø)
petastorm/reader.py 90.69% <66.66%> (ø)
petastorm/pytorch.py 93.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26e03c7...92fa19f. Read the comment docs.

@selitvin selitvin self-requested a review March 23, 2022 04:48
selitvin
selitvin approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@selitvin selitvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@selitvin selitvin merged commit cf1a6e3 into uber:master Apr 14, 2022
@tirkarthi
Copy link
Contributor Author

Thanks @selitvin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selitvin selitvin selitvin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tirkarthi @selitvin