Get rid of RuntimeWarning when using process pool #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
selitvin
force-pushed
the
warning_in_process_pool
branch
from
cd72f4d to
8d90bad
Compare
Restructure process_pool implementation code in a way that resolves `RuntimeWarning: 'petastorm.workers_pool.exec_in_new_process' found in sys.modules after import of package 'petastorm.workers_pool', but prior to execution of 'petastorm.workers_pool.exec_in_new_process'; this may result in unpredictable behaviou when using process pool` warning. In this diff we break main entry point from `exec_in_new_process.py` file into two a separate `exec_in_new_process_entrypoint.py`. Resolves uber#585
selitvin
force-pushed
the
warning_in_process_pool
branch
from
8d90bad to
345aabb
Compare
Codecov Report
@@ Coverage Diff @@
## master #732 +/- ##
==========================================
+ Coverage 86.16% 86.17% +0.01%
==========================================
Files 84 85 +1
Lines 5060 5065 +5
Branches 787 787
==========================================
+ Hits 4360 4365 +5
Misses 560 560
Partials 140 140
Continue to review full report at Codecov.
|
chongxiaoc
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure process_pool implementation code in a way that resolves
RuntimeWarning: 'petastorm.workers_pool.exec_in_new_process' found in sys.modules after import of package 'petastorm.workers_pool', but prior to execution of 'petastorm.workers_pool.exec_in_new_process'; this may result in unpredictable behaviou when using process poolwarning.In this diff we break main entry point from
exec_in_new_process.pyfile into two a separateexec_in_new_process_entrypoint.py.Resolves #585