Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select items by import paths #5518

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Select items by import paths #5518

wants to merge 3 commits into from
+14 −7

Conversation

Myriad-Dreamin
Copy link
Contributor

@Myriad-Dreamin Myriad-Dreamin commented Dec 4, 2024 •
edited
Loading

It is not tested, but I think we are only getting the value from some module by the first component of an import item, so it doesn't check the following code correctly:

#import "@blabla": a.b
                // ^^^ only considered the first component, i.e. the `a`

@laurmaedje
Copy link
Member

Could you add a test for this?

@Myriad-Dreamin
Copy link
Contributor Author

Could you add a test for this?

Sure, but leave me some time to learn and write it :).

@Myriad-Dreamin
Copy link
Contributor Author

I added a test, but unluckily it also passes on main branch..

typst/crates/typst-ide/src/matchers.rs

Line 280 in 54fcdcf

// Cannot test much.

I don't know how do we test matchers with multiple files or extending IDE test framework is out of scope of this PR. How do you think of it?

@laurmaedje
Copy link
Member

The TestWorld does support multiple files. The autocomplete, definition, tooltip tests already use a new, more flexible testing style. The matchers & jump don't yet. If you want, you can take a stab at migrating them as well in a separate PR. Otherwise I'd do it, though not sure when exactly.

@Myriad-Dreamin
Copy link
Contributor Author

If you want, you can take a stab at migrating them as well in a separate PR. Otherwise I'd do it, though not sure when exactly.

I see. We shall create a migration PR first and come back to this PR then.

@laurmaedje
Copy link
Member

@Myriad-Dreamin I'm taking care of the migration right now.

@laurmaedje
Copy link
Member

Done: #5602

@laurmaedje laurmaedje added the waiting-on-author Pull request waits on author label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
waiting-on-author Pull request waits on author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Myriad-Dreamin @laurmaedje