Fix HUSKY_SKIP_INSTALL=1 not skipping install #518
Merged
+10
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable auto-install in the documentation suggests to set
HUSKY_SKIP_INSTALL
to1
to skip automatic installation of Git hooks. However, Husky actually only skipped installation ifHUSKY_SKIP_INSTALL
was set totrue
(instead of1
).I’ve changed the condition to test for both
1
andtrue
(similar to how it’s already done indebug.ts
) and added a test.