Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: link no-duplicate-type-constituents and no-redundant-type-constituents to each other #9612

Merged

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Jul 22, 2024

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 22, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 45a021f
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66a7c39bb7376a00082c88fc
😎 Deploy Preview https://deploy-preview-9612--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 22, 2024
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (bf4abdf) to head (1483c5c).
Report is 10 commits behind head on main.

Current head 1483c5c differs from pull request most recent head 45a021f

Please upload reports for the commit 45a021f to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9612      +/-   ##
==========================================
- Coverage   88.45%   88.45%   -0.01%     
==========================================
  Files         422      422              
  Lines       14696    14695       -1     
  Branches     4299     4298       -1     
==========================================
- Hits        12999    12998       -1     
  Misses       1372     1372              
  Partials      325      325              
Flag Coverage Δ
unittest 88.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@JoshuaKGoldberg JoshuaKGoldberg merged commit 46a5709 into typescript-eslint:main Jul 29, 2024
55 checks passed
@kirkwaiblinger kirkwaiblinger deleted the link-related-rules branch July 29, 2024 17:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants