Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [no-floating-promises] add missing suggestions on main #9569

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Jul 16, 2024

PR Checklist

Overview

CI is broken on main (2d81d1a, https://github.com/typescript-eslint/typescript-eslint/actions/runs/9963500743), since #9043 wasn't fully up to date.

This fixes that!

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit e07cedb
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6696fefcecbc580008872b40
😎 Deploy Preview https://deploy-preview-9569--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e07cedb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.38%. Comparing base (0234ba4) to head (e07cedb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9569   +/-   ##
=======================================
  Coverage   88.37%   88.38%           
=======================================
  Files         419      419           
  Lines       14621    14620    -1     
  Branches     4280     4279    -1     
=======================================
  Hits        12922    12922           
+ Misses       1375     1374    -1     
  Partials      324      324           
Flag Coverage Δ
unittest 88.38% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@kirkwaiblinger kirkwaiblinger merged commit 87ccfb0 into typescript-eslint:main Jul 17, 2024
70 checks passed
@kirkwaiblinger kirkwaiblinger deleted the fix-ci branch July 17, 2024 00:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants