Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: enable no-lonely-if #9547

Merged
merged 4 commits into from
Jul 19, 2024
Merged

chore: enable no-lonely-if #9547

merged 4 commits into from
Jul 19, 2024

Conversation

abrahamguo
Copy link
Contributor

@abrahamguo abrahamguo commented Jul 12, 2024 •
edited by kirkwaiblinger
Loading

PR Checklist

Overview

Enable no-lonely-if (docs).

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jul 12, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 531d444
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/669a6fcb62dc4f00088e9e4d
😎 Deploy Preview https://deploy-preview-9547--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 86 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 12, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 531d444. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@codecov Codecov
Copy link

codecov bot commented Jul 12, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (970f3f1) to head (531d444).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9547   +/-   ##
=======================================
  Coverage   88.40%   88.40%           
=======================================
  Files         422      422           
  Lines       14650    14650           
  Branches     4285     4285           
=======================================
  Hits        12951    12951           
  Misses       1374     1374           
  Partials      325      325
Flag Coverage Δ
unittest 88.40% <94.87%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...eslint-plugin/src/rules/consistent-type-imports.ts 94.77% <100.00%> (ø)
...kages/eslint-plugin/src/rules/func-call-spacing.ts 96.66% <100.00%> (ø)
.../eslint-plugin/src/rules/member-delimiter-style.ts 97.33% <100.00%> (ø)
...s/eslint-plugin/src/rules/no-non-null-assertion.ts 100.00% <100.00%> (ø)
packages/eslint-plugin/src/rules/no-unused-vars.ts 98.74% <100.00%> (ø)
.../rules/prefer-optional-chain-utils/analyzeChain.ts 100.00% <100.00%> (ø)
...ackages/scope-manager/src/referencer/Referencer.ts 95.52% <100.00%> (ø)
packages/typescript-estree/src/convert.ts 28.58% <0.00%> (ø)

@kirkwaiblinger kirkwaiblinger mentioned this pull request Jul 12, 2024
Open
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

kirkwaiblinger
kirkwaiblinger previously approved these changes Jul 18, 2024
View reviewed changes
@Josh-Cena Josh-Cena merged commit 0108e9c into typescript-eslint:main Jul 19, 2024
61 of 63 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024
@abrahamguo abrahamguo deleted the no-lonely-if branch August 20, 2024 00:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Josh-Cena Josh-Cena Josh-Cena approved these changes

@kirkwaiblinger kirkwaiblinger kirkwaiblinger left review comments

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abrahamguo @JoshuaKGoldberg @kirkwaiblinger @Josh-Cena