chore: enable prefer-template #9544

abrahamguo · 2024-07-11T13:50:22Z

PR Checklist

Addresses an existing open issue: fixes part of Repo: enable more core ESLint rules internally #9523
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Enable prefer-template (docs). 100% autofixable.

typescript-eslint · 2024-07-11T13:50:26Z

Thanks for the PR, @abrahamguo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-07-11T13:50:39Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`43e7d8c`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/66a69aa996568400081179f6
😎 Deploy Preview	https://deploy-preview-9544--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 98 (🔴 down 1 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-07-11T13:51:39Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 43e7d8c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 30 targets

Sent with 💌 from NxCloud.

packages/rule-schema-to-typescript-types/src/index.ts

packages/utils/tests/eslint-utils/getParserServices.test.ts

Josh-Cena · 2024-07-11T14:02:01Z

packages/website/tools/generate-website-dts.ts

-      `import type * as ${safeName} from '${from}';\n` +
-      text.replace(regex, safeName)
-    );
+    return `import type * as ${safeName} from '${from}';\n${text.replace(


Make \n a literal character

This is just a curiosity question — do you feel it's a case-by case decision on whether to use an explicit \n vs a literal newline?

I was just curious because there are hundreds of places throughout our codebases that use explicit \ns, so I was wondering if you were in favor of any consistent pattern, or if it just depends?

codecov · 2024-07-11T14:09:52Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.45%. Comparing base (6b92aa5) to head (43e7d8c).
Report is 186 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9544      +/-   ##
==========================================
- Coverage   88.45%   88.45%   -0.01%     
==========================================
  Files         422      422              
  Lines       14695    14694       -1     
  Branches     4298     4298              
==========================================
- Hits        12998    12997       -1     
  Misses       1372     1372              
  Partials      325      325

Flag	Coverage Δ
unittest	`88.45% <100.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...lugin-internal/src/rules/plugin-test-formatting.ts	`79.19% <100.00%> (ø)`
...lugin/src/rules/consistent-generic-constructors.ts	`90.24% <ø> (ø)`
...es/eslint-plugin/src/rules/no-floating-promises.ts	`100.00% <ø> (ø)`
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts	`94.26% <ø> (ø)`
...es/eslint-plugin/src/rules/prefer-function-type.ts	`97.10% <100.00%> (-0.05%)`	⬇️
.../rules/prefer-optional-chain-utils/analyzeChain.ts	`100.00% <ø> (ø)`
packages/eslint-plugin/src/rules/unbound-method.ts	`95.29% <ø> (ø)`
...rc/rules/use-unknown-in-catch-callback-variable.ts	`100.00% <ø> (ø)`

packages/eslint-plugin/tests/docs.test.ts

packages/eslint-plugin/src/rules/prefer-function-type.ts

packages/ast-spec/tests/util/serialize-error.ts

…refer-template

Josh-Cena

Leaving my +1

packages/eslint-plugin/src/rules/prefer-function-type.ts

packages/eslint-plugin/tests/docs.test.ts

…refer-template

Josh-Cena · 2024-08-10T23:27:57Z

I know some of y'all have strong (and different) opinions about code, and this seems like a less straightforward one, so let's get more opinions.

kirkwaiblinger · 2024-08-11T06:56:28Z

As noted in discussion, I'm not a big fan of this approach to solving the reports by this rule. I think we should reach for an aliased variable for cases with anything more than a truly trivial expression in the interpolation.

However, I'll leave an approval to signal there's nothing problematically merge-blocking and that you should feel free to proceed without satisfying my stylistic preferences 🙂

JoshuaKGoldberg

Yeah I'm not super picky here 😄, let's just merge and see how it goes. Thanks!

prefer-template

ea723dd

Josh-Cena reviewed Jul 11, 2024

View reviewed changes

packages/rule-schema-to-typescript-types/src/index.ts Outdated Show resolved Hide resolved

Josh-Cena reviewed Jul 11, 2024

View reviewed changes

packages/utils/tests/eslint-utils/getParserServices.test.ts Outdated Show resolved Hide resolved

Josh-Cena reviewed Jul 11, 2024

View reviewed changes

kirkwaiblinger reviewed Jul 11, 2024

View reviewed changes

packages/eslint-plugin/tests/docs.test.ts Outdated Show resolved Hide resolved

packages/eslint-plugin/src/rules/prefer-function-type.ts Outdated Show resolved Hide resolved

packages/ast-spec/tests/util/serialize-error.ts Outdated Show resolved Hide resolved

kirkwaiblinger mentioned this pull request Jul 12, 2024

Repo: enable more core ESLint rules internally #9523

Open

abrahamguo added 7 commits July 12, 2024 09:08

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

dac4f15

…refer-template

review

f76c552

cleanup

b4257bf

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

8a8dc29

…refer-template

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

dc77725

…refer-template

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

af5c1be

…refer-template

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

6462965

…refer-template

abrahamguo requested review from Josh-Cena and kirkwaiblinger July 23, 2024 11:45

Josh-Cena previously approved these changes Jul 23, 2024

View reviewed changes

packages/eslint-plugin/src/rules/prefer-function-type.ts Show resolved Hide resolved

packages/eslint-plugin/tests/docs.test.ts Outdated Show resolved Hide resolved

abrahamguo added 2 commits July 28, 2024 14:22

Merge branch 'main' of github.com:abrahamguo/typescript-eslint into p…

ac2692e

…refer-template

minor cleanup

43e7d8c

abrahamguo dismissed Josh-Cena’s stale review via 43e7d8c July 28, 2024 19:23

abrahamguo requested a review from Josh-Cena August 10, 2024 22:57

Josh-Cena requested a review from a team August 10, 2024 23:27

kirkwaiblinger approved these changes Aug 11, 2024

View reviewed changes

JoshuaKGoldberg approved these changes Aug 14, 2024

View reviewed changes

JoshuaKGoldberg merged commit 243fb5f into typescript-eslint:main Aug 14, 2024
62 checks passed

JoshuaKGoldberg mentioned this pull request Aug 14, 2024

Repo: CI failures on main around prefer-template #9794

Closed

github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: enable prefer-template #9544

chore: enable prefer-template #9544

abrahamguo commented Jul 11, 2024 •

edited

Loading

typescript-eslint bot commented Jul 11, 2024

netlify bot commented Jul 11, 2024 •

edited

Loading

nx-cloud bot commented Jul 11, 2024 •

edited

Loading

Josh-Cena Jul 11, 2024

abrahamguo Jul 12, 2024

codecov bot commented Jul 11, 2024 •

edited

Loading

Josh-Cena left a comment

Josh-Cena commented Aug 10, 2024

kirkwaiblinger commented Aug 11, 2024

JoshuaKGoldberg left a comment

chore: enable prefer-template #9544

chore: enable prefer-template #9544

Conversation

abrahamguo commented Jul 11, 2024 • edited Loading

PR Checklist

Overview

typescript-eslint bot commented Jul 11, 2024

netlify bot commented Jul 11, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Jul 11, 2024 • edited Loading

☁️ Nx Cloud Report

Josh-Cena Jul 11, 2024

Choose a reason for hiding this comment

abrahamguo Jul 12, 2024

Choose a reason for hiding this comment

codecov bot commented Jul 11, 2024 • edited Loading

Codecov Report

Josh-Cena left a comment

Choose a reason for hiding this comment

Josh-Cena commented Aug 10, 2024

kirkwaiblinger commented Aug 11, 2024

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

abrahamguo commented Jul 11, 2024 •

edited

Loading

netlify bot commented Jul 11, 2024 •

edited

Loading

nx-cloud bot commented Jul 11, 2024 •

edited

Loading

codecov bot commented Jul 11, 2024 •

edited

Loading