feat(eslint-plugin): backport no-unsafe-function type, no-wrapper-object-types from v8 to v7 #9507

JoshuaKGoldberg · 2024-07-06T15:41:55Z

PR Checklist

Addresses an existing open issue: fixes Docs: Mention deprecation and replacement rules in ban-types docs #9503; fixes eslint-plugin: Also backport no-unsafe-function-type and no-wrapper-object-types from v8 to main #9505
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

Also adds the docs touchup requested by #9503 while I'm in the area.

💖

…ect-types from v8 to v7

typescript-eslint · 2024-07-06T15:41:58Z

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2024-07-06T15:42:18Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`cb1ae31`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/669945fd283b390008e3c63e
😎 Deploy Preview	https://deploy-preview-9507--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 92 (🔴 down 2 from production) Accessibility: 100 (no change from production) Best Practices: 92 (no change from production) SEO: 90 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

nx-cloud · 2024-07-06T15:47:32Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cb1ae31. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

kirkwaiblinger · 2024-07-12T06:13:32Z

FYI @JoshuaKGoldberg - I just merged #9363 to v8, so you'll want to update this PR with those changes

kirkwaiblinger

#9507 (comment)

packages/eslint-plugin/docs/rules/no-wrapper-object-types.mdx

packages/eslint-plugin/docs/rules/no-unsafe-function-type.mdx

Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>

JoshuaKGoldberg · 2024-07-17T12:17:56Z

Aha! The check from #9243 is saving us on this one.

kirkwaiblinger

Looks like might need to rerun some test snapshots? Otherwise LGTM

codecov · 2024-07-18T17:19:09Z

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.40%. Comparing base (8258dae) to head (cb1ae31).
Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9507      +/-   ##
==========================================
+ Coverage   88.38%   88.40%   +0.01%     
==========================================
  Files         419      422       +3     
  Lines       14620    14652      +32     
  Branches     4279     4287       +8     
==========================================
+ Hits        12922    12953      +31     
  Misses       1374     1374              
- Partials      324      325       +1

Flag	Coverage Δ
unittest	`88.40% <96.66%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
...eslint-plugin/src/rules/no-unsafe-function-type.ts	`100.00% <100.00%> (ø)`
...eslint-plugin/src/rules/no-wrapper-object-types.ts	`100.00% <100.00%> (ø)`
packages/eslint-plugin/src/util/scopeUtils.ts	`75.00% <75.00%> (ø)`

kirkwaiblinger

🚀

feat(eslint-plugin): backport no-unsafe-function type, no-wrapper-obj…

efe6eb4

…ect-types from v8 to v7

fix: lint

5ec359b

kirkwaiblinger requested changes Jul 12, 2024

View reviewed changes

JoshuaKGoldberg added 2 commits July 13, 2024 12:26

Brought in the rewording

e94c264

Remove v8 label in relations

6b8d0bc

JoshuaKGoldberg requested a review from kirkwaiblinger July 13, 2024 16:30

kirkwaiblinger reviewed Jul 13, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-wrapper-object-types.mdx Outdated Show resolved Hide resolved

kirkwaiblinger reviewed Jul 13, 2024

View reviewed changes

packages/eslint-plugin/docs/rules/no-unsafe-function-type.mdx Outdated Show resolved Hide resolved

JoshuaKGoldberg and others added 2 commits July 13, 2024 14:11

Apply suggestions from code review

711319e

Co-authored-by: Kirk Waiblinger <kirk.waiblinger@gmail.com>

Remove remaining v8's

d6a084e

JoshuaKGoldberg requested a review from kirkwaiblinger July 13, 2024 18:12

bradzacher previously approved these changes Jul 14, 2024

View reviewed changes

bradzacher added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 14, 2024

kirkwaiblinger previously approved these changes Jul 14, 2024

View reviewed changes

ran yarn generate-configs

64972b7

JoshuaKGoldberg dismissed stale reviews from kirkwaiblinger and bradzacher via 64972b7 July 17, 2024 03:11

kirkwaiblinger previously approved these changes Jul 17, 2024

View reviewed changes

fix: configs

faa3223

JoshuaKGoldberg dismissed kirkwaiblinger’s stale review via faa3223 July 17, 2024 12:19

kirkwaiblinger approved these changes Jul 17, 2024

View reviewed changes

kirkwaiblinger requested changes Jul 17, 2024

View reviewed changes

JoshuaKGoldberg added 2 commits July 18, 2024 12:37

fix: snapshots

b8c810c

Merge branch 'main' into more-ban-types-rules-v7

cb1ae31

kirkwaiblinger approved these changes Jul 18, 2024

View reviewed changes

JoshuaKGoldberg merged commit dd965a4 into typescript-eslint:main Jul 18, 2024
61 of 63 checks passed

JoshuaKGoldberg deleted the more-ban-types-rules-v7 branch July 18, 2024 17:36

kirkwaiblinger mentioned this pull request Jul 22, 2024

docs: remove unnecessary v8 links #9611

Merged

3 tasks

github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(eslint-plugin): backport no-unsafe-function type, no-wrapper-object-types from v8 to v7 #9507

feat(eslint-plugin): backport no-unsafe-function type, no-wrapper-object-types from v8 to v7 #9507

JoshuaKGoldberg commented Jul 6, 2024

typescript-eslint bot commented Jul 6, 2024

netlify bot commented Jul 6, 2024 •

edited

Loading

nx-cloud bot commented Jul 6, 2024 •

edited

Loading

kirkwaiblinger commented Jul 12, 2024 •

edited

Loading

kirkwaiblinger left a comment

JoshuaKGoldberg commented Jul 17, 2024

kirkwaiblinger left a comment

codecov bot commented Jul 18, 2024

kirkwaiblinger left a comment

feat(eslint-plugin): backport no-unsafe-function type, no-wrapper-object-types from v8 to v7 #9507

feat(eslint-plugin): backport no-unsafe-function type, no-wrapper-object-types from v8 to v7 #9507

Conversation

JoshuaKGoldberg commented Jul 6, 2024

PR Checklist

Overview

typescript-eslint bot commented Jul 6, 2024

netlify bot commented Jul 6, 2024 • edited Loading

✅ Deploy Preview for typescript-eslint ready!

nx-cloud bot commented Jul 6, 2024 • edited Loading

☁️ Nx Cloud Report

kirkwaiblinger commented Jul 12, 2024 • edited Loading

kirkwaiblinger left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg commented Jul 17, 2024

kirkwaiblinger left a comment

Choose a reason for hiding this comment

codecov bot commented Jul 18, 2024

Codecov Report

kirkwaiblinger left a comment

Choose a reason for hiding this comment

netlify bot commented Jul 6, 2024 •

edited

Loading

nx-cloud bot commented Jul 6, 2024 •

edited

Loading

kirkwaiblinger commented Jul 12, 2024 •

edited

Loading