Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ast-spec): add parent property to AccessorProperty node types #9487

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Adds parent: ClassBody to the AccessorPropertyComputedName interfaces to start on #6225.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 33e6882
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6686af8a40420c0007d3750c
😎 Deploy Preview https://deploy-preview-9487--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jul 3, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 33e6882. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg requested a review from Josh-Cena July 3, 2024 21:58
@kirkwaiblinger kirkwaiblinger added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jul 3, 2024
kirkwaiblinger
kirkwaiblinger previously approved these changes Jul 3, 2024
Josh-Cena
Josh-Cena previously approved these changes Jul 3, 2024
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...! Easier than I thought.

@Josh-Cena
Copy link
Member

Question: is this actually part of the AST? My impression was that ESLint injected parent. Did that change recently?

@JoshuaKGoldberg JoshuaKGoldberg dismissed stale reviews from Josh-Cena and kirkwaiblinger via fbebcef July 4, 2024 00:20
@JoshuaKGoldberg
Copy link
Member Author

D'oh! Right, these augmentations should exist in packages/types. Good spot. 👍

@JoshuaKGoldberg JoshuaKGoldberg merged commit ceb9b88 into typescript-eslint:main Jul 5, 2024
63 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants