Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [prefer-nullish-coalescing] handle intersected primitive types #9378

Conversation

jakebailey
Copy link
Collaborator

@jakebailey jakebailey commented Jun 17, 2024

PR Checklist

Overview

For a union like string & { __brand?: any } | undefined, treat the intersection like a primitive; this helps cases like branded Path types.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @jakebailey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 71ec3ed
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6670884b1f157c0008f6bb47
😎 Deploy Preview https://deploy-preview-9378--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 97 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

nx-cloud bot commented Jun 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71ec3ed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gif of a guy lazily saying "welcome to COSTCO ... I love you"

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 18, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 23e6468 into typescript-eslint:main Jun 24, 2024
67 of 70 checks passed
@jakebailey jakebailey deleted the prefer-nullish-coalescing-intersections branch June 24, 2024 16:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [prefer-nullish-coalescing] ignorePrimitives does not ignore intersected primitives
2 participants