Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [no-unsafe-call] differentiate a types-error any from a true any #9304

Merged
merged 7 commits into from
Jul 1, 2024
Merged

fix(eslint-plugin): [no-unsafe-call] differentiate a types-error any from a true any #9304

merged 7 commits into from
Jul 1, 2024

Conversation

Vinccool96
Copy link
Contributor

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Vinccool96!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 7, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 2735d4d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/66802e286dcd210008101f14
😎 Deploy Preview https://deploy-preview-9304--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Vinccool96 Vinccool96 changed the title fix(eslint-plugin): [no-unsafe-member-access] differentiate a types-error any from a true any fix(eslint-plugin): [no-unsafe-call differentiate a types-error any from a true any Jun 7, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 7, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 2735d4d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@Vinccool96 Vinccool96 force-pushed the fix/eslint-plugin/no-unsafe-call-differentiate-types-error branch from 433931a to 8360a5f Compare June 7, 2024 15:36
@Vinccool96 Vinccool96 changed the title fix(eslint-plugin): [no-unsafe-call differentiate a types-error any from a true any fix(eslint-plugin): [no-unsafe-call] differentiate a types-error any from a true any Jun 7, 2024
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jun 8, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean & readable code - a good start! Requesting changes to fit in a bit with the other PRs, and some testing please. Thanks! ✨

packages/eslint-plugin/src/rules/no-unsafe-call.ts Outdated Show resolved Hide resolved
packages/eslint-plugin/tests/rules/no-unsafe-call.test.ts Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 8, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 8, 2024
JoshuaKGoldberg
JoshuaKGoldberg requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than reverting the description changes, this looks great - thanks for updating the tests! 🧹

packages/eslint-plugin/docs/rules/no-unsafe-call.mdx Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg added awaiting response Issues waiting for a reply from the OP or another party 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge and removed 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge labels Jun 11, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 17, 2024
@Vinccool96 Vinccool96 force-pushed the fix/eslint-plugin/no-unsafe-call-differentiate-types-error branch from ed8008f to eed523f Compare June 17, 2024 16:25
@Vinccool96 Vinccool96 force-pushed the fix/eslint-plugin/no-unsafe-call-differentiate-types-error branch from eed523f to c1390ff Compare June 25, 2024 14:37
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 29, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 29, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 29, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 swell, thank you!

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jun 29, 2024
@JoshuaKGoldberg JoshuaKGoldberg merged commit 05142c5 into typescript-eslint:main Jul 1, 2024
64 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@StyleShit StyleShit Awaiting requested review from StyleShit

Assignees
No one assigned
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unsafe-call] Differentiate a types-error any from a "true" any
3 participants
@Vinccool96 @JoshuaKGoldberg @StyleShit