Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [no-unsafe-return] differentiate a types-error any from a true any #9254

Merged
merged 6 commits into from
Jun 26, 2024
Merged

fix(eslint-plugin): [no-unsafe-return] differentiate a types-error any from a true any #9254

merged 6 commits into from
Jun 26, 2024

Conversation

developer-bandi
Copy link
Contributor

@developer-bandi developer-bandi commented Jun 4, 2024 •
edited
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @developer-bandi!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4a1e15b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6665ae90378c37000886dad6
😎 Deploy Preview https://deploy-preview-9254--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 90 (🔴 down 8 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@developer-bandi developer-bandi changed the title fix(eslint-plugin): [no-unsafe-return] Differentiate a types-error any from a "true" fix(eslint-plugin): [no-unsafe-return] differentiate a types-error any from a "true" Jun 4, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4a1e15b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@Josh-Cena Josh-Cena changed the title fix(eslint-plugin): [no-unsafe-return] differentiate a types-error any from a "true" fix(eslint-plugin): [no-unsafe-return] differentiate a types-error any from a true any Jun 4, 2024
@developer-bandi
Copy link
Contributor Author

ci test is fail, but i don't know reason. may be yarn install is fail, but give me a advice to resolve this error?

@JoshuaKGoldberg
Copy link
Member

@developer-bandi looks it might have been a random transient issue. My advice for that is to first try updating the branch from the latest main, or if it's already up-to-date, pushing a small commit. I'm updating from main now`.

Just a heads up, it looks like you've got formatting issues in the code that would fail the build. So I'll mark this as awaiting response preemptively.

@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 8, 2024
JoshuaKGoldberg
JoshuaKGoldberg reviewed Jun 8, 2024
View reviewed changes
packages/eslint-plugin/tests/rules/no-unsafe-return.test.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Testing] As with #8304, please include the data in existing tests. If there's a bug in the new isErrorType ? ... : ... logic, the tests should be able to catch it.

JoshuaKGoldberg
JoshuaKGoldberg requested changes Jun 8, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 10, 2024
@JoshuaKGoldberg JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Jun 11, 2024
@github-actions github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 26, 2024
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word "Stellar" with a sparkling light traveling through the 'S', over a starfield

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3694d8f into typescript-eslint:main Jun 26, 2024
64 of 65 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [no-unsafe-return] Differentiate a types-error any from a "true" any
2 participants
@developer-bandi @JoshuaKGoldberg