Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: ensure 'breaking change' label for PRs that touch stable configs #9243

Merged
merged 2 commits into from
Jun 4, 2024
Merged

chore: ensure 'breaking change' label for PRs that touch stable configs #9243

merged 2 commits into from
Jun 4, 2024

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jun 4, 2024 •
edited
Loading

PR Checklist

Overview

Combines:

  1. https://github.com/marketplace/actions/changed-files: to check whether the stable configs were changed
  2. https://github.com/marketplace/actions/require-labels: to require the breaking change when any stable config was changed

For an example CI failure, see JoshuaKGoldberg#322 -> JoshuaKGoldberg#322 (comment):

🤖 Beep boop! PRs that change our stable preset configs must be labeled with breaking change.

💖

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Jun 4, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 45d051c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/665e876a66b9210008f12faf
😎 Deploy Preview https://deploy-preview-9243--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jun 4, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 45d051c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 31 targets

Sent with 💌 from NxCloud.

@JoshuaKGoldberg JoshuaKGoldberg changed the title ci: ensure 'breaking change' label for PRs that touch stable configs chore: ensure 'breaking change' label for PRs that touch stable configs Jun 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team June 4, 2024 01:00
@bradzacher bradzacher merged commit c1a257e into typescript-eslint:main Jun 4, 2024
61 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the ci-pr-labels branch June 4, 2024 10:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Repo: Require PRs that change config presets to be marked as breaking changes
2 participants
@JoshuaKGoldberg @bradzacher