Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow parserOptions.project: false #8339

Merged
merged 5 commits into from
Feb 4, 2024
Merged

feat: allow parserOptions.project: false #8339

merged 5 commits into from
Feb 4, 2024

Conversation

bradzacher
Copy link
Member

Overview

More splitting out of #7935.
This change allows us to pass false to parserOptions.project.
This allows us to work-around eslint/eslint#17820 not being in ESLint v8

@bradzacher bradzacher added the enhancement New feature or request label Feb 2, 2024
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify Netlify
Copy link

netlify bot commented Feb 2, 2024 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 639b2fa
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65bef20da96e97000878cfad
😎 Deploy Preview https://deploy-preview-8339--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 89 (🔴 down 1 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (421a99a) 87.71% compared to head (7897bec) 87.72%.
Report is 20 commits behind head on main.

❗ Current head 7897bec differs from pull request most recent head 639b2fa. Consider uploading reports for the commit 639b2fa to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8339   +/-   ##
=======================================
  Coverage   87.71%   87.72%           
=======================================
  Files         397      397           
  Lines       13963    13971    +8     
  Branches     4061     4065    +4     
=======================================
+ Hits        12248    12256    +8     
  Misses       1403     1403           
  Partials      312      312
Flag Coverage Δ
unittest 87.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...-estree/src/parseSettings/getProjectConfigFiles.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@bradzacher bradzacher changed the title feat: allow false for parserOptons.project feat: allow parserOptions.project: false Feb 2, 2024
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell! 🙌

docs/packages/Parser.mdx Outdated Show resolved Hide resolved
docs/packages/TypeScript_ESTree.mdx Outdated Show resolved Hide resolved
packages/typescript-estree/src/parseSettings/getProjectConfigFiles.ts Show resolved Hide resolved
@bradzacher @JoshuaKGoldberg
Update docs/packages/Parser.mdx
1be8375 
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@bradzacher @JoshuaKGoldberg
Update docs/packages/TypeScript_ESTree.mdx
7897bec 
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Feb 3, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 639b2fa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 33 targets

Sent with 💌 from NxCloud.

@bradzacher bradzacher merged commit a893105 into main Feb 4, 2024
57 of 59 checks passed
@bradzacher bradzacher deleted the allow-false-for-projects branch February 4, 2024 02:22
danvk pushed a commit to danvk/typescript-eslint that referenced this pull request Feb 4, 2024
@bradzacher @danvk
feat: allow parserOptions.project: false (typescript-eslint#8339)
5d00bae
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bradzacher @JoshuaKGoldberg