-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [no-unused-vars] don't report on types referenced in export assignment expression #8265
Conversation
… in export assignment expression
Thanks for the PR, @auvred! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 🚀
Will leave open with the 1 approval
label in case another team member has time to review before the Monday release. Scope analysis can be tricky.
I don't have experience with the scope analyzer, but if the tests are passing it LGTM. |
It looks like this introduced a regression into import type Foo from 'foo';
// Type import "Foo" is used by decorator metadata
export = {} as Foo; filed #8330 |
… in export assignment expression (typescript-eslint#8265)
PR Checklist
Overview
Explicitly visit
TSExportAssignment
's expression, so if it contains some type, that type gets a new reference