Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unused-vars] don't report on types referenced in export assignment expression #8265

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

auvred
Copy link
Member

@auvred auvred commented Jan 17, 2024

PR Checklist

Overview

Explicitly visit TSExportAssignment's expression, so if it contains some type, that type gets a new reference

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Jan 17, 2024

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 8b6c1ce
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65a7b2d9ac170a0008e800e7
😎 Deploy Preview https://deploy-preview-8265--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 94 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀

Will leave open with the 1 approval label in case another team member has time to review before the Monday release. Scope analysis can be tricky.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Jan 17, 2024
@Josh-Cena
Copy link
Member

I don't have experience with the scope analyzer, but if the tests are passing it LGTM.

@JoshuaKGoldberg JoshuaKGoldberg merged commit dae7ddf into typescript-eslint:main Jan 29, 2024
58 checks passed
@bradzacher
Copy link
Member

bradzacher commented Feb 1, 2024

It looks like this introduced a regression into consistent-type-imports.

import type Foo from 'foo';
// Type import "Foo" is used by decorator metadata

export = {} as Foo;

filed #8330

danvk pushed a commit to danvk/typescript-eslint that referenced this pull request Feb 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: [@typescript-eslint/no-unused-vars] False positive on export-equals syntax
4 participants