Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): [playground] add twoslash queries #8119

Merged
merged 7 commits into from
Feb 2, 2024

Conversation

auvred
Copy link
Member

@auvred auvred commented Dec 24, 2023

PR Checklist

Overview

The issue is not marked as accepting prs, so I'm opening it as a draft for now

upd: undrafting ¯\_(ツ)_/¯


I took this code from microsoft/Typescript-Website and refactored it a bit

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @auvred!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Dec 24, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 90d2e78
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/65bbc5640831500008a6808a
😎 Deploy Preview https://deploy-preview-8119--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (🟢 up 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@auvred auvred marked this pull request as ready for review February 1, 2024 15:19
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Feb 1, 2024
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 This looks great, thanks for such a clean PR!

No blocking requests from me - just a comment change for a more searchable TS 4.3/4.4 reference, and a couple of small style touchups that we can ignore them if you hate them 😄. WDYT?

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Feb 1, 2024
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
@bradzacher bradzacher merged commit 5c253a8 into typescript-eslint:main Feb 2, 2024
63 checks passed
danvk pushed a commit to danvk/typescript-eslint that referenced this pull request Feb 4, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Website: Add twoslash queries to the playground
3 participants