Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): simplify a sentence in no-misused-promises.md #8050

Merged

Conversation

huyenltnguyen
Copy link
Contributor

@huyenltnguyen huyenltnguyen commented Dec 11, 2023

PR Checklist

Overview

This PR updates a sentence in the no-misused-promises doc to use active voice in order to make the sentence a little more concise.


Sending ❤️ to the team (and hey, I did read https://typescript-eslint.io/contributing/pull-requests/ 😄).

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @huyenltnguyen!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

Copy link

netlify bot commented Dec 11, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9c7efa3
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/657753826490240008d7163e
😎 Deploy Preview https://deploy-preview-8050--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 91 (🔴 down 6 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, this sentence took me a few re-reads to understand... +1 on improving its clarity. Thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3175843 into typescript-eslint:main Dec 11, 2023
59 of 64 checks passed
@huyenltnguyen huyenltnguyen deleted the docs/active-voice branch December 12, 2023 03:10
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants